HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43348 )
Change subject: nb/intel/sandybridge: Add missing includes ......................................................................
Patch Set 8:
(15 comments)
https://review.coreboot.org/c/coreboot/+/43348/8/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/chip.h:
https://review.coreboot.org/c/coreboot/+/43348/8/src/northbridge/intel/sandy... PS8, Line 17: u8 stdint
https://review.coreboot.org/c/coreboot/+/43348/8/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/common.c:
https://review.coreboot.org/c/coreboot/+/43348/8/src/northbridge/intel/sandy... PS8, Line 10: get_platform_id model_206ax.h
https://review.coreboot.org/c/coreboot/+/43348/8/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/gma.h:
https://review.coreboot.org/c/coreboot/+/43348/8/src/northbridge/intel/sandy... PS8, Line 10: u32 stdint.h
https://review.coreboot.org/c/coreboot/+/43348/8/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/memmap.c:
https://review.coreboot.org/c/coreboot/+/43348/8/src/northbridge/intel/sandy... PS8, Line 16: uintptr_t stdint.h
https://review.coreboot.org/c/coreboot/+/43348/8/src/northbridge/intel/sandy... PS8, Line 37: size_t stddef.h
https://review.coreboot.org/c/coreboot/+/43348/8/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit.h:
https://review.coreboot.org/c/coreboot/+/43348/8/src/northbridge/intel/sandy... PS8, Line 10: u8 stdint.h
https://review.coreboot.org/c/coreboot/+/43348/8/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/c/coreboot/+/43348/8/src/northbridge/intel/sandy... PS8, Line 35: u8 stdint.h
https://review.coreboot.org/c/coreboot/+/43348/8/src/northbridge/intel/sandy... PS8, Line 121: size_t stddef.h
https://review.coreboot.org/c/coreboot/+/43348/8/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_mrc.c:
https://review.coreboot.org/c/coreboot/+/43348/8/src/northbridge/intel/sandy... PS8, Line 49: u16 stdint.h
https://review.coreboot.org/c/coreboot/+/43348/8/src/northbridge/intel/sandy... PS8, Line 352: size_t stddef.h
https://review.coreboot.org/c/coreboot/+/43348/8/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_native.h:
https://review.coreboot.org/c/coreboot/+/43348/8/src/northbridge/intel/sandy... PS8, Line 11: u8 stdint.h
https://review.coreboot.org/c/coreboot/+/43348/8/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_native.c:
https://review.coreboot.org/c/coreboot/+/43348/8/src/northbridge/intel/sandy... PS8, Line 27: u32 stdint.h
https://review.coreboot.org/c/coreboot/+/43348/8/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_tables.h:
https://review.coreboot.org/c/coreboot/+/43348/8/src/northbridge/intel/sandy... PS8, Line 8: u32 only stdint.h is needed
https://review.coreboot.org/c/coreboot/+/43348/8/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_tables.c:
https://review.coreboot.org/c/coreboot/+/43348/8/src/northbridge/intel/sandy... PS8, Line 6: u32 stdint.h
https://review.coreboot.org/c/coreboot/+/43348/8/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/sandybridge.h:
https://review.coreboot.org/c/coreboot/+/43348/8/src/northbridge/intel/sandy... PS8, Line 32: u8 stdint.h