Attention is currently required from: Tim Wawrzynczak, EricR Lai.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52185 )
Change subject: mb/google/brya: Add FPMCU power control
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/52185/comment/fed4abae_4bdc37d3
PS2, Line 377: 0
Is this required? What is the default state of FP_RST_ODL when the platform is taken out of reset (i.e. booting out of S5/G3)? Configuring the pad to driven low here will result in FPMCU not working after S3 resume.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52185
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8a8fae80c3cc186e0a097ab2007abb656f382cbd
Gerrit-Change-Number: 52185
Gerrit-PatchSet: 2
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Mon, 12 Apr 2021 03:30:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment