[coreboot-gerrit] Change in coreboot[master]: security/vboot/sync_ec: Add timestamps

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36209 )

Change subject: security/vboot/sync_ec: Add timestamps
......................................................................

Patch Set 20:

(2 comments)

https://review.coreboot.org/c/coreboot/+/36209/20/src/commonlib/include/comm... 
File src/commonlib/include/commonlib/timestamp_serialized.h:

https://review.coreboot.org/c/coreboot/+/36209/20/src/commonlib/include/comm... 
PS20, Line 86: 	TS_EC_HASH_READY = 554,
> nit: I think there's an intentional split between vboot stuff and non-vboot stuff here, so maybe ins […]

Fair enough.

https://review.coreboot.org/c/coreboot/+/36209/20/src/security/vboot/ec_sync... 
File src/security/vboot/ec_sync.c:

https://review.coreboot.org/c/coreboot/+/36209/20/src/security/vboot/ec_sync... 
PS20, Line 473: 	timestamp_add_now(TS_END_EC_SYNC);
> nit: Is there a reason this is here and not at the end of vboot_sync_ec()? That would seem a bit mor […]

Now that you say something it does look kinda weird.  Will move.