Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42246 )
Change subject: mb/google/volteer/malefor: Update overridetree.cb ......................................................................
Patch Set 2:
(1 comment)
Patch Set 1:
(1 comment)
Patch Set 1:
(1 comment)
i see you're adding support for multiple audio DBs. is that just copy-paste from volteer or is that intended for malefor?
You're right, I copied volteer audio solution and removed "drivers/intel/soundwire". Malefor doesn't use max98373, I'll submit a new patchset to remove all the max98373 driver.
the next question is whether you even need the "probe" statement. if you plan to support exactly one audio board, you don't really need to probe. all the probe is going to do is to consult the fw_config bits to see if you have a matching audio DB type specified. this is pretty much redundant unless you want to be able to specify "none" for the audio DB as an option - this might be useful for testing.
anyway, think about whether malefor needs to use the audio DB type field in fw_config at all.
https://review.coreboot.org/c/coreboot/+/42246/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/malefor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42246/2/src/mainboard/google/voltee... PS2, Line 50: extra blank line?