mturney mturney has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35494 )
Change subject: sc7180: Provide initial SoC support ......................................................................
Patch Set 8:
Patch Set 8:
Patch Set 8: -Code-Review
Can you please add some documentation about the SoC to the docs/ directory? Also a brief description of the SoC to the commit message would be good. What kind of arm core does it use? What peripherals does it have?
I'll leave it up to T.mike to see how much of this he can accommodate. Maybe we can add something about the peripherals for which drivers are already uploaded, like an overview of how the QUPs work?
That would be great.
But please understand that there may be some information (e.g. probably CPU core specs) that Qualcomm doesn't want to publish at this time.
Sure. I know how it works.
By docs/ directory I assume you are referencing Documentation/ at top-level? A review of this folder's contents leaves me with these impressions: * current documentation is heavily x-86 centric * there is no SoC docs for an ARMv8 core * there is only single google board (dragonegg) and this is a how-to, not a what-is
I share this, not as an indictment so much as an explanation of what I will face when I bring this request up to my boss. The first response will be along the lines of either A) provide what other ARMv8 boards provide or B) what do other ARMv8 boards document?
As Julius has alluded to, my masters guard the corporate IP very closely and would probably suggest that technical info on sc7180 is already available in public domain.
I will discuss with Julius offline and add some detail to commit message, I doubt a new file under Documentation/ can be justified for the amount of info that is likely to be made available.