Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/63540 )
Change subject: mb/google/guybrush: Disable EN_SPKR on init on Nipperkin and Dewatt ......................................................................
mb/google/guybrush: Disable EN_SPKR on init on Nipperkin and Dewatt
We don't want to enable the speaker on init. It will be enabled while using GPIO AMP codec in depthcharge.
BUG=b:223289882 TEST=boot Nipperkin and Dewatt and then verify the devbeep and gpio values in kernel
Signed-off-by: Yu-Hsuan Hsu yuhsuan@google.com Change-Id: Id874421d7464b15be6e521576696bb97e6b22d6a Reviewed-on: https://review.coreboot.org/c/coreboot/+/63540 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Raul Rangel rrangel@chromium.org --- M src/mainboard/google/guybrush/variants/baseboard/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Raul Rangel: Looks good to me, approved
diff --git a/src/mainboard/google/guybrush/variants/baseboard/gpio.c b/src/mainboard/google/guybrush/variants/baseboard/gpio.c index fff98d2..53ff85b 100644 --- a/src/mainboard/google/guybrush/variants/baseboard/gpio.c +++ b/src/mainboard/google/guybrush/variants/baseboard/gpio.c @@ -82,7 +82,7 @@ /* SD_AUX_RESET_L */ PAD_GPO(GPIO_69, HIGH), /* EN_SPKR */ - PAD_GPO(GPIO_70, HIGH), + PAD_GPO(GPIO_70, LOW), /* GPIO_71 - GPIO_73: Not available */ /* Unused TP49 */ PAD_NC(GPIO_74),