Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31304
to look at the new patch set (#3).
Change subject: device/pci_ops: Move questionable pci_locate() variants ......................................................................
device/pci_ops: Move questionable pci_locate() variants
These are defined for __SIMPLE_DEVICE__ when PCI enumeration has not happened yet. These should not really try to probe devices other than those on bus 0.
It's hard to track but there maybe cases of southbridge being located on bus 2 and available for configuration, so I rather leave the code unchanged. Just move these out of arch/io.h because they cause build failures if one attempts to include <arch/pci_ops.h> before <arch/io.h>.
There are two direct copies for ROMCC bootblocks to avoid inlining them elsewhere.
Change-Id: Ida2919a5d83fe5ea89284ffbd8ead382e4312524 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/arch/x86/include/arch/io.h M src/device/pci_early.c M src/include/device/pci.h M src/southbridge/amd/amd8111/bootblock.c M src/southbridge/amd/amd8111/reset.c M src/southbridge/amd/sb700/early_setup.c M src/southbridge/broadcom/bcm5785/bootblock.c M src/southbridge/intel/i82371eb/bootblock.c M src/southbridge/intel/i82371eb/early_pm.c M src/southbridge/intel/i82371eb/early_smbus.c M src/southbridge/nvidia/ck804/early_smbus.c M src/southbridge/nvidia/mcp55/early_smbus.c 12 files changed, 88 insertions(+), 45 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/31304/3