Attention is currently required from: Crystal Guo, Hung-Te Lin, Xi Chen, Xixi Chen, Yidi Lin.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80687?usp=email )
Change subject: soc/mediatek: Add `MEDIATEK_DRAM_ADAPTIVE` config to support dram adaptive
......................................................................
Patch Set 3:
(1 comment)
File src/soc/mediatek/common/memory.c:
https://review.coreboot.org/c/coreboot/+/80687/comment/5adf7d74_f9b23628 :
PS3, Line 316: if (CONFIG(MEDIATEK_DRAM_ADAPTIVE)) {
```
const struct sdram_info *sdram_param = NULL;
static struct sdram_info fake_sdram_param;
if (CONFIG(MEDIATEK_DRAM_ADAPTIVE))
sdram_param = &fake_sdram_param;
else
sdram_param = get_sdram_config();
mt_mem_ini_run(dparam, sdram_param);
```
I think the compiler will eliminate `fake_sdram_param` if `!MEDIATEK_DRAM_ADAPTIVE`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80687?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I05a01b1ab13fbf19b2a908c48a540a5c2e1ccbdc
Gerrit-Change-Number: 80687
Gerrit-PatchSet: 3
Gerrit-Owner: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Crystal Guo
crystal.guo@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Xi Chen
xixi.chen@mediatek.com
Gerrit-Attention: Crystal Guo
crystal.guo@mediatek.corp-partner.google.com
Gerrit-Attention: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Fri, 23 Feb 2024 08:39:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment