Attention is currently required from: Paul Menzel, Stefan Reinauer, Julius Werner, Arthur Heymans.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54385 )
Change subject: Documentation: Add proposal to allow enabling serial console with a flag
......................................................................
Patch Set 4:
(1 comment)
File Documentation/technotes/2021-05-selectable-serial-console.md:
https://review.coreboot.org/c/coreboot/+/54385/comment/4d3ac7f0_5339793d
PS1, Line 112: and change the default to whatever is found there.
SGTM in general, but you removed the part about forgoing the bootblock now? That part is still imp […]
Thanks for the feedback, I incorporated it.
As for the "avoid recursion" bit, I'm not sure this must be part of the document but I'll certainly ensure that the implementation takes care of that and has comments about it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54385
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If1b0efc55880095f9d5d6d6e448f2c8677d57ff5
Gerrit-Change-Number: 54385
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 04 Jun 2021 12:25:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment