Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68087 )
Change subject: nb/intel/i945/rcven.c: Use read32p() ......................................................................
nb/intel/i945/rcven.c: Use read32p()
Tested on unsupported mainboard (945g-m4).
Signed-off-by: Elyes Haouas ehaouas@noos.fr Change-Id: I1935308cc50abd651b52d6290d66180905c6a521 Reviewed-on: https://review.coreboot.org/c/coreboot/+/68087 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martin.roth@amd.corp-partner.google.com --- M src/northbridge/intel/i945/rcven.c 1 file changed, 18 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, but someone else must approve Martin Roth: Looks good to me, approved
diff --git a/src/northbridge/intel/i945/rcven.c b/src/northbridge/intel/i945/rcven.c index 37b568a..7d497e6 100644 --- a/src/northbridge/intel/i945/rcven.c +++ b/src/northbridge/intel/i945/rcven.c @@ -29,8 +29,8 @@ }
for (i = 0; i < 28; i++) { - read32((void *)addr); - read32((void *)(addr + 0x80)); + read32p(addr); + read32p(addr + 0x80); }
reg32 = mchbar_read32(RCVENMT);