Attention is currently required from: Xi Chen, Martin Roth, Yu-Ping Wu.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49448 )
Change subject: mb/google/asurada: Add generic DRAM groups
......................................................................
Patch Set 7:
(3 comments)
File src/mainboard/google/asurada/sdram_configs.c:
https://review.coreboot.org/c/coreboot/+/49448/comment/45334cab_12a20417
PS1, Line 10:
Extra blank line.
Done
https://review.coreboot.org/c/coreboot/+/49448/comment/8143008b_e721cba3
PS1, Line 124:
Extra blank lines.
Done
File src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-DISCRETE-2RANK-8GB.c:
https://review.coreboot.org/c/coreboot/+/49448/comment/af75ae59_96f49d34
PS2, Line 6: .ddr_geometry = DDR_TYPE_2CH_2RK_8GB_4_4,
8GB may contains normal mode and byte mode, the calibration flow is different. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49448
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia89cc26a3b18a60f18b38906f0ac13b1e8c86416
Gerrit-Change-Number: 49448
Gerrit-PatchSet: 7
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Xi Chen
xixi.chen@mediatek.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 25 Feb 2021 08:55:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Xi Chen
xixi.chen@mediatek.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment