build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57057 )
Change subject: WIP: Herobrine: Initialize Pen and HP i2c devices ......................................................................
Patch Set 1:
(4 comments)
File src/mainboard/google/herobrine/chromeos.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126413): https://review.coreboot.org/c/coreboot/+/57057/comment/f48b812b_f78a25ba PS1, Line 44: i2c_init(0x0, I2C_SPEED_FAST); /* Audio - QUP 0*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126413): https://review.coreboot.org/c/coreboot/+/57057/comment/70552832_bab38da2 PS1, Line 44: i2c_init(0x0, I2C_SPEED_FAST); /* Audio - QUP 0*/ please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126413): https://review.coreboot.org/c/coreboot/+/57057/comment/79fae80d_9457898f PS1, Line 45: i2c_init(0xF, I2C_SPEED_FAST); /* PEN - QUP 15*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126413): https://review.coreboot.org/c/coreboot/+/57057/comment/a29ed73a_4221f214 PS1, Line 45: i2c_init(0xF, I2C_SPEED_FAST); /* PEN - QUP 15*/ please, no spaces at the start of a line