Martin Roth has posted comments on this change. ( https://review.coreboot.org/19300 )
Change subject: arch/x86: Share storage data structures between early stages ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/19300/3/src/arch/x86/Kconfig File src/arch/x86/Kconfig:
PS3, Line 244: : # Allocate space in CAR to share the driver storage structures between stages : config CAR_DRIVERS_STORAGE : bool : default n If we need this, could it go in drivers/storage/kconfig instead of here?
https://review.coreboot.org/#/c/19300/3/src/arch/x86/car.ld File src/arch/x86/car.ld:
PS3, Line 47: CONFIG_CAR_DRIVERS_STORAGE can this just be CONFIG_DRIVERS_STORAGE, and we always allocate it if we're using DRIVERS_STORAGE?