Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33512 )
Change subject: soc/intel/cannonlake: set use of legacy 8254 timer
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/33512/3/src/soc/intel/cannonlake/Kconfig
File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/#/c/33512/3/src/soc/intel/cannonlake/Kconfig@320
PS3, Line 320: default n if PAYLOAD_SEABIOS
: default y
is this correct? as per your commit msg, i guess default should be "n" that mean 8254 is not disable […]
nope, reversed the meaning of the Kconfig but not the logic. fixed in #4
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33512
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0e888bf754cb72093f14fc02f39bddcd6d288203
Gerrit-Change-Number: 33512
Gerrit-PatchSet: 4
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jeremy Soller
jackpot51@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 16 Jun 2019 06:05:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment