[coreboot-gerrit] Change in coreboot[master]: util: Add spd_tools to generate DDR4 SPDs for TGL boards

[Nick Vaccaro (Code Review)]

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44429 )

Change subject: util: Add spd_tools to generate DDR4 SPDs for TGL boards
......................................................................

Patch Set 19:

(2 comments)

https://review.coreboot.org/c/coreboot/+/44429/11/util/spd_tools/intel/ddr4/... 
File util/spd_tools/intel/ddr4/gen_spd.go:

https://review.coreboot.org/c/coreboot/+/44429/11/util/spd_tools/intel/ddr4/... 
PS11, Line 1420: width != 8
> Sounds okay. Good to have that documented.

It was documented in the README in that DeviceBusWidth's only valid options are 8 and 16.  I added a "NOTE:" at that location in the readme to spell out that x4 parts are not supported by this tool.

https://review.coreboot.org/c/coreboot/+/44429/16/util/spd_tools/intel/ddr4/... 
File util/spd_tools/intel/ddr4/global_ddr4_mem_parts.json.txt:

https://review.coreboot.org/c/coreboot/+/44429/16/util/spd_tools/intel/ddr4/... 
PS16, Line 30:                 "speedMbps": 3200,
> Mbps or MTps?

Good catch.