Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42373 )
Change subject: mainboard/hp: Add ProBook 6360b ......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42373/9/src/ec/hp/kbc1126/ec.c File src/ec/hp/kbc1126/ec.c:
https://review.coreboot.org/c/coreboot/+/42373/9/src/ec/hp/kbc1126/ec.c@117 PS9, Line 117: kbc1126_kbdled(conf->ec_ctrl_reg, 0); : : /* The EC needs additional time to process the first command on a cold : boot. */ : int timeout = 0x17ff; : while ((inb(conf->ec_cmd_port) & KBD_IBF) && --timeout) : It's better to make a separate commit for this.
kbc1126_kbdled also sends EC commands. Since the EC fails to receive commands, does the CapsLock LED blink many times on cold boots?