[coreboot-gerrit] [XS] Change in coreboot[main]: soc/intel/meteorlake: Add PsysPmax configuration

[Martin L Roth (Code Review)]

Attention is currently required from: Eran Mitrani, Jakub Czapiga, Paul Menzel, Subrata Banik, Tarun, Tarun Tuli.

Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76796?usp=email )

The change is no longer submittable: All-Comments-Resolved is unsatisfied now.

Change subject: soc/intel/meteorlake: Add PsysPmax configuration
......................................................................

Patch Set 10:

(4 comments)

File src/soc/intel/meteorlake/chip.h:

https://review.coreboot.org/c/coreboot/+/76796/comment/7b915343_fcedf0f5 :
PS10, Line 450: 	/* Platform Power Pmax in Watts */
Add comment about 0 being automatic?

https://review.coreboot.org/c/coreboot/+/76796/comment/827569c0_4b4365d8 :
PS10, Line 451: psys_pmax
Maybe change to psys_pmax_watts? Then the unit is obvious in devicetree.

File src/soc/intel/meteorlake/chip.h:

https://review.coreboot.org/c/coreboot/+/76796/comment/2b17d5ab_96641fd8 :
PS6, Line 444: PsysPmax
> Done

Snackcase - I like it. hostess_psys_pmax. little_debbie_psys_pmax.

File src/soc/intel/meteorlake/romstage/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/76796/comment/11184962_c49035c5 :
PS3, Line 245: {
> Done

Note that braces *are* allowed for single statement in the coreboot project, even if they're not required. Many people feel that they *should* be required all the time.