Attention is currently required from: Raul Rangel, Martin Roth, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer.
Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74593 )
Change subject: mb/google/myst: Add named GPIO's
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/myst/variants/baseboard/include/baseboard/gpio.h:
https://review.coreboot.org/c/coreboot/+/74593/comment/ac304224_a9afc0d0
PS2, Line 30: #define LPC_RST_L_MB GPIO_32
This is named `LPC_RST_L` in go/myst-gpios.
LPC_RST_L is a macro defined by AMD for pin function and naming this the same way will conflict with that definition.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74593
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6832316d704959f61fe05b9bb23f449e562af7ed
Gerrit-Change-Number: 74593
Gerrit-PatchSet: 2
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer
markhas@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Mark Hasemeyer
markhas@google.com
Gerrit-Comment-Date: Fri, 21 Apr 2023 20:12:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Gerrit-MessageType: comment