Attention is currently required from: Andrey Petrov, Kapil Porwal, Nick Vaccaro, Paul Menzel.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76921?usp=email )
Change subject: drivers/intel/fsp2_0: Add API to convert BMP images to GOP BLT buffer ......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76921/comment/f222f644_87a03625 : PS3, Line 18: It also adds a : new config (BMP_LOGO_TO_GOP_BLT) to ensure backward compatibility with : older generation FSP.
I meant, if `BMP_LOGO` is selected, then build in the BMP to GOP BLT conversion always.
UPDs are different between just passing BMP image to FSP vs GOP BLT to FSP.
Are you saying pass the GOP BLT by default (if BMP_LOGO is enabled) ?
File src/drivers/intel/fsp2_0/fsp_gop_blt.c:
PS3:
Maybe the same structs could be used for coreboot in general, and then only the structs are converted, and the newly added function would be common code. coreboot’s splash screen feature also supports BMP, so having a checker for that could be used there too.
why would coreboot like to convert BMP into GOP BLT format (for EFI header efi_graphics_output_blt_pixel). As mentioned earlier GOP BLT format is more for UEFI BMP driver code. I don't see any value at this stage to adopt this solution for common code beyond just FSP driver.
if coreboot would like to render the BMP image to the framebuffer, we shouldn't be relying on the efi_graphics_output_blt_pixel structure.