Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40278 )
Change subject: mb/purism/librem_whl: Add new board Librem Mini (WHL-U) ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40278/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40278/2//COMMIT_MSG@10 PS2, Line 10:
Could you please give more details to the board (URL maybe), and document, how it was tested?
documentation added in CB:42882
https://review.coreboot.org/c/coreboot/+/40278/1/src/mainboard/purism/librem... File src/mainboard/purism/librem_whl/romstage.c:
https://review.coreboot.org/c/coreboot/+/40278/1/src/mainboard/purism/librem... PS1, Line 28: .dqs_map[DDR_CH0] = {0, 1, 3, 2, 4, 5, 6, 7},
That shouldn't be needed for regular DDR4
Done
https://review.coreboot.org/c/coreboot/+/40278/1/src/mainboard/purism/librem... PS1, Line 40: values for Cannon Lake : { 80, 40, 40, 40, 30 }
I think we can drop this. Maybe replace with the names of the values? […]
Done