Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42062 )
Change subject: src/*: Update makefiles to exclude x86 code from non-x86 verstage
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42062/3/src/drivers/pc80/pc/Makefil...
File src/drivers/pc80/pc/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42062/3/src/drivers/pc80/pc/Makefil...
PS3, Line 11: verstage-y += i8254.c
That seems reasonable. […]
Ya. That sounds like a good solution.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42062
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I797b67394825172bd44ad1ee693a0c509289486b
Gerrit-Change-Number: 42062
Gerrit-PatchSet: 3
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 10 Jun 2020 19:36:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment