Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68135 )
Change subject: soc/amd: Add an optional unsigned section in PSP verstage
......................................................................
Patch Set 9:
(1 comment)
File src/soc/amd/common/block/cpu/noncar/memlayout_psp_verstage.ld:
https://review.coreboot.org/c/coreboot/+/68135/comment/8e425ef3_a56f3a6a
PS9, Line 25: ALIGN
Doesn't this need to move up one line if you want the anchor to be aligned to 64 bytes?
PSP_FOOTER_DATA already takes care of it. It is already starting at address that is aligned to 64 bytes and is 64 bytes in size.
Hence the anchor is already starting at an address aligned to 64 bytes. This is to ensure that the entire binary is still aligned to 64 bytes after the anchor is introduced. Anchor currently is at size 0x8c. This alignment makes it to hit 0xc0.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68135
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I308223be8fbca1c0bec8c2e1c86ed65d9f91b966
Gerrit-Change-Number: 68135
Gerrit-PatchSet: 9
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 21 Oct 2022 16:27:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment