Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42839 )
Change subject: superio/nuvoton: Avoid NULL pointer dereference
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/42839/1/src/superio/nuvoton/npcd378...
File src/superio/nuvoton/npcd378/superio.c:
https://review.coreboot.org/c/coreboot/+/42839/1/src/superio/nuvoton/npcd378...
PS1, Line 329: acpigen_write_scope(scope);
just not writing the scope, but the rest from this scope will likely result in broken AML code being generated
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42839
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc253c63aadef1c0ecb116a38b608f64f80abc79
Gerrit-Change-Number: 42839
Gerrit-PatchSet: 1
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 26 Jun 2020 20:37:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment