Attention is currently required from: Jason Glenesk, Raul Rangel, Ian Feng, Matt DeVillier, Chris Wang, Tim Van Patten, Fred Reitberger, Karthikeyan Ramasubramanian, Felix Held.
EricKY Cheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68469 )
Change subject: soc/amd/mendocino: Expand extra 5 DPTC thermal related profiles
......................................................................
Patch Set 4:
(1 comment)
File src/soc/amd/mendocino/chip.h:
https://review.coreboot.org/c/coreboot/+/68469/comment/4430d80a_67fbbf3f
PS4, Line 77: uint32_t sustained_power_limit_mW_B;
: uint32_t fast_ppt_limit_mW_B;
: uint32_t slow_ppt_limit_mW_B;
: uint32_t slow_ppt_time_constant_s_B;
: uint32_t thermctl_limit_degreeC_B;
From the tables in b/248086651, how are you deciding which values need entries here? […]
1. OK, I will remove the same for everything items.
2. The items list here are for the thermal table expansion design in the future.
2.1. Based on previous co-operation experience with thermal team on lock-down the tables in b/248086651, these parameters list here are probability changed in further tuning.
2.2. There are some table parameters that I don't list here as you expect because based on previous co-operation experience with thermal team on lock-down the tables in b/248086651, thermal team did't request to change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68469
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie03de155325cbb340fce09848327ff7fa33ab1fd
Gerrit-Change-Number: 68469
Gerrit-PatchSet: 4
Gerrit-Owner: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 21 Oct 2022 03:15:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Gerrit-MessageType: comment