Attention is currently required from: Arthur Heymans, Angel Pons, Patrick Rudolph.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61938 )
Change subject: nb/intel/ironlake: Fix sending HECI messages
......................................................................
Patch Set 7: Code-Review+1
(2 comments)
File src/northbridge/intel/ironlake/raminit.c:
https://review.coreboot.org/c/coreboot/+/61938/comment/e3858b87_572374a9
PS5, Line 1539: length - i < sizeof(dword) ? length - i : sizeof(dword)
Done
is it?
File src/southbridge/intel/ibexpeak/setup_heci_uma.c:
https://review.coreboot.org/c/coreboot/+/61938/comment/56c9844a_b473692e
PS7, Line 54: (head->length - 1) / sizeof(u32)
This used to be rounded up and + 1 (for the head I guess), iow. the number
of writes we are going to do to DEFAULT_HECIBAR+0. I don't understand the change.
If I didn't miss anything:
wait_heci_cb_avail(DIV_RONUD_UP(sizeof(*head) + head->length, sizeof(u32)));
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61938
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5bb4ca4b27f8554208b12da177c51091ea6a108f
Gerrit-Change-Number: 61938
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 15 Feb 2022 14:04:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment