8 Oct
2022
8 Oct
'22
10:03 a.m.
Attention is currently required from: Arthur Heymans, Karthik Ramasubramanian, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68234 )
Change subject: util/amdfwread: Fix cookie error message ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File util/amdfwtool/amdfwread.c:
https://review.coreboot.org/c/coreboot/+/68234/comment/cbee4b93_6650fd7b PS1, Line 84: ERR("Invalid PSP header cookie value found: 0x%x, expected: 0x%x\n", The usual ordering is "expected foo, got bar instead". But this is now correct, which is more important.
--
To view, visit https://review.coreboot.org/c/coreboot/+/68234
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I580675fcbf8c5058ade371c6b9edb7b7070a78a3
Gerrit-Change-Number: 68234
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sat, 08 Oct 2022 10:03:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment