Attention is currently required from: Sridhar Siricilla, Paul Menzel, Ravindra, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55364 )
Change subject: soc/intel/alderlake: [WIP]Trigger cse_fw_sync before DRAM Init
......................................................................
Patch Set 6:
(1 comment)
File src/soc/intel/alderlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/55364/comment/ceeae825_18d0a610
PS3, Line 133: if (!s3wake) {
: if (CONFIG(SOC_INTEL_CSE_LITE_SKU))
Nit: You could put it in one line.
e.g.
```
if (CONFIG(SOC_INTEL_CSE_LITE_SKU) && !s3wake)
cse_fw_sync();
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55364
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad7403650df8bc4e40aa6e48ccfeba95a5789a2d
Gerrit-Change-Number: 55364
Gerrit-PatchSet: 6
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ravindra
ravindra@intel.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 07 Oct 2021 18:57:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment