Hello Vladimir Serbinenko,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/36229
to review the following change.
Change subject: mb/lenovo/x201/acpi: Merge common platform ASL code. ......................................................................
mb/lenovo/x201/acpi: Merge common platform ASL code.
This code in reality just describes the southbridge features, don't put a copy in every mainboard.
This commit follows up on commit e288758b with Change-Id I8cf3019a36b1ae6a17d502e7508f36ea9fa62830 ("bd82x6x: Merge common platform ASL code").
Change-Id: Ic5260461165b794a13efd2c6d968c953f60dd253 Signed-off-by: Vladimir Serbinenko phcoder@gmail.com Signed-off-by: Peter Lemenkov lemenkov@gmail.com --- M src/mainboard/lenovo/x201/acpi/platform.asl M src/mainboard/lenovo/x201/dsdt.asl 2 files changed, 2 insertions(+), 30 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/36229/1
diff --git a/src/mainboard/lenovo/x201/acpi/platform.asl b/src/mainboard/lenovo/x201/acpi/platform.asl index 685c6ab..bcd6de6 100644 --- a/src/mainboard/lenovo/x201/acpi/platform.asl +++ b/src/mainboard/lenovo/x201/acpi/platform.asl @@ -14,36 +14,6 @@ * GNU General Public License for more details. */
-/* The APM port can be used for generating software SMIs */ - -OperationRegion (APMP, SystemIO, 0xb2, 2) -Field (APMP, ByteAcc, NoLock, Preserve) -{ - APMC, 8, /* APM command */ - APMS, 8 /* APM status */ -} - -/* SMI I/O Trap */ -Method(TRAP, 1, Serialized) -{ - Store (Arg0, SMIF) /* SMI Function */ - Store (0, TRP0) /* Generate trap */ - Return (SMIF) /* Return value of SMI handler */ -} - -/* The _PIC method is called by the OS to choose between interrupt - * routing via the i8259 interrupt controller or the APIC. - * - * _PIC is called with a parameter of 0 for i8259 configuration and - * with a parameter of 1 for Local Apic/IOAPIC configuration. - */ - -Method(_PIC, 1) -{ - /* Remember the OS' IRQ routing choice. */ - Store(Arg0, PICM) -} - /* The _PTS method (Prepare To Sleep) is called before the OS is * entering a sleep state. The sleep state number is passed in Arg0 */ diff --git a/src/mainboard/lenovo/x201/dsdt.asl b/src/mainboard/lenovo/x201/dsdt.asl index 461892b..08e2122 100644 --- a/src/mainboard/lenovo/x201/dsdt.asl +++ b/src/mainboard/lenovo/x201/dsdt.asl @@ -30,6 +30,8 @@ 0x20130325 /* OEM revision */ ) { + #include <southbridge/intel/bd82x6x/acpi/platform.asl> + /* Some generic macros */ #include "acpi/platform.asl"