Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33449 )
Change subject: soc/intel/common: Fix booting issue without default IGD enabled ......................................................................
Patch Set 2:
(2 comments)
Patch Set 2:
I think the cause of this could be a configuration issue. If RUN_FSP_GOP is selected but the IGD disabled, it would run into this path. Checking if the IGD is actually enabled, in fill_lb_framebuffer() in drivers/intel/fsp2_0/graphics.c, might be a more elegant solution.
yes, let me do that as well
https://review.coreboot.org/#/c/33449/2/src/soc/intel/common/block/graphics/... File src/soc/intel/common/block/graphics/graphics.c:
https://review.coreboot.org/#/c/33449/2/src/soc/intel/common/block/graphics/... PS2, Line 62: return 0;
Why is it ok to return 0 here if we have to die() below? This seems […]
Looks like called of graphics_get_memory_base() function has non-zero value check so it might able to know if framebuffer is available or not
https://review.coreboot.org/#/c/33449/2/src/soc/intel/common/block/graphics/... PS2, Line 81: die
I guess die() is appropriate as the users of this function do not check for any errors.
yes, this code can't get call in case IGD is disable still just an additional check to block user.