[coreboot-gerrit] Change in coreboot[master]: vendorcode/google/chromeos: Introduce helper for CSE board reset

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44646 )

Change subject: vendorcode/google/chromeos: Introduce helper for CSE board reset
......................................................................

Patch Set 6: Code-Review+2

(2 comments)

https://review.coreboot.org/c/coreboot/+/44646/5/src/vendorcode/google/chrom... 
File src/vendorcode/google/chromeos/Kconfig:

https://review.coreboot.org/c/coreboot/+/44646/5/src/vendorcode/google/chrom... 
PS5, Line 101: .
> so that cr50 resets the TPM state. […]

I think it would be good to add the above to help text as well just to make it clear why this Kconfig is used.

https://review.coreboot.org/c/coreboot/+/44646/6/src/vendorcode/google/chrom... 
File src/vendorcode/google/chromeos/cse_board_reset.c:

https://review.coreboot.org/c/coreboot/+/44646/6/src/vendorcode/google/chrom... 
PS6, Line 25: if (version.epoch != 0 || version.major != 0 || version.minor > 22)
            : 		return;
            : 
We should get a confirmation about this from Mary/Namyoon.