Attention is currently required from: Knox Chiou, Paul Menzel, Xinxiong Xu, Yidi Lin, Yu-Ping Wu.
Yang Wu has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/84342?usp=email )
Change subject: mb/google/corsola: Distinguish MT8186T's SKU ID from MT8186
......................................................................
Patch Set 10:
(2 comments)
File src/mainboard/google/corsola/boardid.c:
https://review.coreboot.org/c/coreboot/+/84342/comment/67a49de4_e79681be?usp... :
PS8, Line 119: cached_sku_code
Align with `cached_sku_code` above.
Done
https://review.coreboot.org/c/coreboot/+/84342/comment/a21d49cf_039e3579?usp... :
PS8, Line 125: if (CONFIG(BOARD_GOOGLE_STARYU_COMMON)) {
Keep the `/* Reserve last 4 bits to report PANEL_ID */` comment.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84342?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I91306d3abd508e104851916882fb36a4fd302036
Gerrit-Change-Number: 84342
Gerrit-PatchSet: 10
Gerrit-Owner: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Knox Chiou
knoxchiou@google.com
Gerrit-Reviewer: Xinxiong Xu
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Knox Chiou
knoxchiou@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Xinxiong Xu
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Thu, 19 Sep 2024 05:47:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com