Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42276 )
Change subject: soc/intel/tigerlake: Add CmdMirror option in chip.h
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42276/2/src/soc/intel/tigerlake/chi...
File src/soc/intel/tigerlake/chip.h:
https://review.coreboot.org/c/coreboot/+/42276/2/src/soc/intel/tigerlake/chi...
PS2, Line 86: LPDDR4x
I don't believe the mirroring is LPDDR4 specific.
https://review.coreboot.org/c/coreboot/+/42276/2/src/soc/intel/tigerlake/rom...
File src/soc/intel/tigerlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/42276/2/src/soc/intel/tigerlake/rom...
PS2, Line 200: LPDDR4x
same
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42276
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idae9fa439f077f8f3fb16fe74c2f263c008cd5f4
Gerrit-Change-Number: 42276
Gerrit-PatchSet: 2
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 11 Jun 2020 22:18:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment