Attention is currently required from: Julius Werner. Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63026 )
Change subject: soc/qualcomm/common: verify size of memchipinfo structure ......................................................................
Patch Set 2:
(7 comments)
File src/commonlib/bsd/include/commonlib/bsd/mem_chip_info.h:
https://review.coreboot.org/c/coreboot/+/63026/comment/28bc89a0_bacdd618 PS1, Line 5:
This needs to #include <stddef.h> for size_t now.
Done
https://review.coreboot.org/c/coreboot/+/63026/comment/a521263c_acdf73ad PS1, Line 28: static inline size_t mem_chip_info_size(struct mem_chip_info *info) {
open brace '{' following function definitions go on the next line […]
Done
https://review.coreboot.org/c/coreboot/+/63026/comment/32a2e73c_c69afd9e PS1, Line 29: return sizeof(*info) + sizeof(info->channel[0]) * info->num_channels;
please, no spaces at the start of a line […]
Done
File src/soc/qualcomm/common/qclib.c:
https://review.coreboot.org/c/coreboot/+/63026/comment/4ed6119f_c1a230d8 PS1, Line 31: mem_chip_info_size(&memchip)
No you're supposed to check the mem_chip_info at te->blob_address, not some random mem_chip_info you […]
Done
https://review.coreboot.org/c/coreboot/+/63026/comment/b7b963a3_d170c361 PS1, Line 51: sizeof(struct mem_chip_info)
mem_chip_info_size(mem_chip_addr)
Done
https://review.coreboot.org/c/coreboot/+/63026/comment/42899f55_f88643f4 PS1, Line 55: memchip
Again this is supposed to be mem_chip_addr here.
Done
https://review.coreboot.org/c/coreboot/+/63026/comment/6d53fffe_0027fc6f PS1, Line 186: mem_chip_addr, sizeof(mem_chip_addr), 0);
I left more comments in the other CL, please address all of them (and mark them Done in that CL so w […]
Done