Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68489 )
Change subject: soc/mediatek/mt8188: Update mtcmos settings for display and audio
......................................................................
Patch Set 6:
(2 comments)
File src/soc/mediatek/common/mtcmos.c:
https://review.coreboot.org/c/coreboot/+/68489/comment/446cf4f1_8bb910bc
PS5, Line 17: {
Move to next line […]
removed
https://review.coreboot.org/c/coreboot/+/68489/comment/01494d0d_2631cce2
PS5, Line 24: mtcmos_set_scpd_ext_buck_iso(pd);
If this is controlled by `SCPD_EXT_BUCK_ISO`, why do we need the weak function? Can't we write […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68489
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7f00bda0cc5c7f8dea55a564a0ff10ae601115b3
Gerrit-Change-Number: 68489
Gerrit-PatchSet: 6
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Mon, 24 Oct 2022 03:39:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment