Attention is currently required from: Felix Singer, Lance Zhao, Jason Glenesk, Raul Rangel, Nico Huber, Furquan Shaikh, Marshall Dawson, Tim Wawrzynczak, Angel Pons, Patrick Rudolph, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58118 )
Change subject: acpigen,soc/amd/cezanne,intel/{common,skl}: rework CPPC table passing ......................................................................
Patch Set 6:
(10 comments)
File src/soc/amd/cezanne/cppc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130116): https://review.coreboot.org/c/coreboot/+/58118/comment/e9469bd3_121731c6 PS6, Line 15: [CPPC_HIGHEST_PERF] = CPPC_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_HIGHEST_PERF, 8), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130116): https://review.coreboot.org/c/coreboot/+/58118/comment/fa77c562_505fa2c1 PS6, Line 16: [CPPC_NOMINAL_PERF] = CPPC_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_NOMINAL_PERF, 8), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130116): https://review.coreboot.org/c/coreboot/+/58118/comment/b8101c06_a5336f6c PS6, Line 17: [CPPC_LOWEST_NONL_PERF] = CPPC_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_LOW_NON_LIN_PERF, 8), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130116): https://review.coreboot.org/c/coreboot/+/58118/comment/4e6a16c4_0fff24e9 PS6, Line 18: [CPPC_LOWEST_PERF] = CPPC_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_LOWEST_PERF, 8), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130116): https://review.coreboot.org/c/coreboot/+/58118/comment/f06e905f_8163660c PS6, Line 20: [CPPC_DESIRED_PERF] = CPPC_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_DES_PERF, 8), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130116): https://review.coreboot.org/c/coreboot/+/58118/comment/c3b7622a_9ecba681 PS6, Line 21: [CPPC_MIN_PERF] = CPPC_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_MIN_PERF, 8), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130116): https://review.coreboot.org/c/coreboot/+/58118/comment/47f0c28f_f87032d0 PS6, Line 22: [CPPC_MAX_PERF] = CPPC_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_MAX_PERF, 8), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130116): https://review.coreboot.org/c/coreboot/+/58118/comment/a5f9b685_944e03b8 PS6, Line 26: [CPPC_REF_PERF_COUNTER] = CPPC_REG_MSR(MSR_MAX_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130116): https://review.coreboot.org/c/coreboot/+/58118/comment/794cd797_2cacd18e PS6, Line 27: [CPPC_DELIVERED_PERF_COUNTER] = CPPC_REG_MSR(MSR_ACTUAL_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130116): https://review.coreboot.org/c/coreboot/+/58118/comment/883a4e31_cd2bbeba PS6, Line 34: [CPPC_PERF_PREF] = CPPC_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_ENERGY_PERF_PREF, 8), line over 96 characters