Attention is currently required from: Jincheng Li.
Hello Jincheng Li,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/83328?usp=email
to review the following change.
Change subject: mb/intel/avenuecity_crb: Update SMBIOS type 0,1,2,3 info ......................................................................
mb/intel/avenuecity_crb: Update SMBIOS type 0,1,2,3 info
Update BIOS version and unset card bus plugin support. Update mainboard info, wake-up type and SKU number. Update mainboard asset tag and feature flags. Update mainboard enclosure type, chassis version, chassis serial number and chassis power cords.
Change-Id: I8e68c057fefa1d408fb8d69fef066cb573c929a4 Signed-off-by: Li, Jincheng jincheng.li@intel.com --- M src/mainboard/intel/avenuecity_crb/Kconfig M src/mainboard/intel/avenuecity_crb/ramstage.c 2 files changed, 54 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/83328/1
diff --git a/src/mainboard/intel/avenuecity_crb/Kconfig b/src/mainboard/intel/avenuecity_crb/Kconfig index fff244e..5fc8207 100644 --- a/src/mainboard/intel/avenuecity_crb/Kconfig +++ b/src/mainboard/intel/avenuecity_crb/Kconfig @@ -22,10 +22,18 @@ string default "intel/avenuecity_crb"
+config MAINBOARD_VENDOR + string + default "Intel Corporation" + config MAINBOARD_PART_NUMBER string default "Avenue City CRB"
+config MAINBOARD_SERIAL_NUMBER + string + default "UNKNOWN" + config FMDFILE string default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/board.fmd" diff --git a/src/mainboard/intel/avenuecity_crb/ramstage.c b/src/mainboard/intel/avenuecity_crb/ramstage.c index 1db2568..e1876bd 100644 --- a/src/mainboard/intel/avenuecity_crb/ramstage.c +++ b/src/mainboard/intel/avenuecity_crb/ramstage.c @@ -1,5 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
+#include <smbios.h> #include <soc/dimm_slot.h> #include <soc/ramstage.h>
@@ -8,6 +9,51 @@
}
+const char *smbios_mainboard_bios_version(void) +{ + return "UNKNOWN"; +} + +smbios_wakeup_type smbios_system_wakeup_type(void) +{ + return SMBIOS_WAKEUP_TYPE_POWER_SWITCH; +} + +const char *smbios_system_sku(void) +{ + return "UNKNOWN"; +} + +const char *smbios_mainboard_asset_tag(void) +{ + return "UNKNOWN"; +} + +u8 smbios_mainboard_feature_flags(void) +{ + return SMBIOS_FEATURE_FLAGS_HOSTING_BOARD | SMBIOS_FEATURE_FLAGS_REPLACEABLE; +} + +smbios_enclosure_type smbios_mainboard_enclosure_type(void) +{ + return SMBIOS_ENCLOSURE_RACK_MOUNT_CHASSIS; +} + +const char *smbios_chassis_version(void) +{ + return "UNKNOWN"; +} + +const char *smbios_chassis_serial_number(void) +{ + return "UNKNOWN"; +} + +u8 smbios_chassis_power_cords(void) +{ + return 1; +} + void smbios_fill_dimm_locator(const struct dimm_info *dimm, struct smbios_type17 *t) { int size;