Nick Vaccaro has submitted this change. ( https://review.coreboot.org/c/coreboot/+/76051?usp=email )
(
3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/google/brya/acpi: Set power down delay to 2ms after PEXVDD ......................................................................
mb/google/brya/acpi: Set power down delay to 2ms after PEXVDD
Reduce the delay between PEXVDD and NVVDD from 3ms to 2ms during power down sequences. The hardware discharge is aggressive enough that we can safely optimize this.
BUG=b:288267305 TEST=build and measured delay is acceptable
Signed-off-by: Tarun Tuli taruntuli@google.com Change-Id: I7c65301414044487e50bbbca618c4e602e571cfb Reviewed-on: https://review.coreboot.org/c/coreboot/+/76051 Reviewed-by: Nick Vaccaro nvaccaro@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Eric Lai eric_lai@quanta.corp-partner.google.com --- M src/mainboard/google/brya/acpi/power.asl M src/mainboard/google/brya/variants/hades/variant.c 2 files changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved Nick Vaccaro: Looks good to me, approved
diff --git a/src/mainboard/google/brya/acpi/power.asl b/src/mainboard/google/brya/acpi/power.asl index a51bcaa..7eb31d8 100644 --- a/src/mainboard/google/brya/acpi/power.asl +++ b/src/mainboard/google/brya/acpi/power.asl @@ -140,7 +140,7 @@ #if CONFIG(BOARD_GOOGLE_AGAH) Sleep (10) #else - Sleep (3) + Sleep (2) #endif
/* Deassert EN_PPVAR_GPU_NVVDD */ @@ -290,7 +290,7 @@ #if CONFIG(BOARD_GOOGLE_AGAH) Sleep (10) #else - Sleep (3) + Sleep (2) #endif
/* Ramp down NVVDD */ diff --git a/src/mainboard/google/brya/variants/hades/variant.c b/src/mainboard/google/brya/variants/hades/variant.c index 0864ec0..48e2652 100644 --- a/src/mainboard/google/brya/variants/hades/variant.c +++ b/src/mainboard/google/brya/variants/hades/variant.c @@ -61,7 +61,7 @@ /* In GCOFF entry order (i.e., power-off order) */ static struct power_rail_sequence gpu_off_seq[] = { { "FBVDD", FBVDD_PWR_EN, false, FBVDD_PG, 0,}, - { "PEXVDD", PEXVDD_PWR_EN, false, PEXVDD_PG, 3,}, + { "PEXVDD", PEXVDD_PWR_EN, false, PEXVDD_PG, 2,}, { "NVVDD+MSVDD", NVVDD_PWR_EN, false, NVVDD_PG, 2,}, { "GPU 3.3V", GPU_3V3_PWR_EN, false, GPU_3V3_PG, 4,}, { "GPU 1.8V", GPU_1V8_PWR_EN, false, GPU_1V8_PG, 0,},