Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Paul Menzel, ritul guru.
Anand Vaikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74069?usp=email )
Change subject: mb/amd/mayan:Enable the DT and M.2 SSD1 PCIE slots
......................................................................
Patch Set 14:
(2 comments)
File src/mainboard/amd/mayan/Kconfig:
https://review.coreboot.org/c/coreboot/+/74069/comment/3759de86_b0384703 :
PS13, Line 82: choice
there probably should be a blank line above this
Done
File src/mainboard/amd/mayan/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/74069/comment/8213eb5f_1a45a859 :
PS13, Line 158:
extra line can be removed
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74069?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id141e5e55ef6e25722b411975a59c9764b86f624
Gerrit-Change-Number: 74069
Gerrit-PatchSet: 14
Gerrit-Owner: Anand Vaikar
a.vaikar2021@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ritul guru
ritul.bits@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: ritul guru
ritul.bits@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 08 Jun 2023 11:31:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-MessageType: comment