Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56321 )
Change subject: soc/amd/common/block/lpc/spi_dma: Yield after completing transaction
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/common/block/lpc/spi_dma.c:
https://review.coreboot.org/c/coreboot/+/56321/comment/b42d9cce_1d8ab697
PS1, Line 187: udelay(0);
I think you should use thread_yield_microseconds(0) instead of udelay(0) if you want to just explicitly yield to coop threads. That way the code itself explains what that's for and you don't need a comment to explain it. (We could also make a thread_yield() as an argument-less shortcut for thread_yield_microseconds(0) if that becomes a commonly needed thing.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56321
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9c1272bde46c3e0c15305b76c2ea7a6dde5ed0b0
Gerrit-Change-Number: 56321
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 15 Jul 2021 01:07:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment