Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42662 )
Change subject: sb/intel/i82801gx: Use common early SPI code ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42662/1/src/southbridge/intel/i8280... File src/southbridge/intel/i82801gx/bootblock.c:
https://review.coreboot.org/c/coreboot/+/42662/1/src/southbridge/intel/i8280... PS1, Line 10: enable_spi_prefetching_and_caching
maybe stupid question, but is this needed even if BOOT_DEVICE_NOT_SPI_FLASH = True?
This is currently done unconditionally. I am not changing the behavior of the code with this commit. It doesn't help enabling this if `BOOT_DEVICE_NOT_SPI_FLASH` is selected, but it doesn't seem to hurt either.