Attention is currently required from: Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Kenneth Chan, Nick Vaccaro, Rishika Raj.
Paul Menzel has posted comments on this change by Kenneth Chan. ( https://review.coreboot.org/c/coreboot/+/84091?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/brya/var/nova: Add scaler I2C configuration
......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84091/comment/fa1bd2bb_dd92db2f?usp... :
PS3, Line 7: Add scaler I2C configuration
Maybe: Configure scaler I2C GPIOs
https://review.coreboot.org/c/coreboot/+/84091/comment/07a90102_912b1053?usp... :
PS3, Line 9: pins(PCH_I2C_SCALER_SDA/SDL)
Please add a space before the (.
https://review.coreboot.org/c/coreboot/+/84091/comment/326852ff_dbed284a?usp... :
PS3, Line 10:
Please document the source like the schematics.
https://review.coreboot.org/c/coreboot/+/84091/comment/ecae660c_60c3fe30?usp... :
PS3, Line 12: TEST=emerge-constitution coreboot chromeos-bootimage
How can your change be verified?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84091?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id831f594d6a57ed10867ae5ba05ae98c90ac7d9b
Gerrit-Change-Number: 84091
Gerrit-PatchSet: 3
Gerrit-Owner: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Rishika Raj
rishikaraj@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Rishika Raj
rishikaraj@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 26 Aug 2024 11:33:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No