Attention is currently required from: Angel Pons, Felix Singer, Jason Glenesk, Martin L Roth.
Nicholas Chin has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/84046?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: Docs/releases: Update 24.08 release notes ......................................................................
Patch Set 1:
(12 comments)
File Documentation/releases/coreboot-24.08-relnotes.md:
PS1: Enclose all URLs in angle brackets so that they are rendered as links: ex. `<url here>`
https://review.coreboot.org/c/coreboot/+/84046/comment/d4e3ba7e_1712d2b4?usp... : PS1, Line 16: november ```suggestion November. ```
https://review.coreboot.org/c/coreboot/+/84046/comment/d0827cc5_36e99a34?usp... : PS1, Line 38: Ticket: https://ticket.coreboot.org/issues/522 : Review: https://review.coreboot.org/79905 Newlines without a blank line don't get rendered, so these appear on the same line. Add a `` character after the first line to explicitly add a line break without adding a blank space that a blank line (new paragraph) would ```suggestion Ticket: https://ticket.coreboot.org/issues/522 \ Review: https://review.coreboot.org/79905 ```
https://review.coreboot.org/c/coreboot/+/84046/comment/29b58785_fa189231?usp... : PS1, Line 82: [1] https://lore.kernel.org/qemu-devel/1504626814-23124-1-git-send-email-peter.m... : [2] https://review.coreboot.org/c/coreboot/+/34774 : [3] https://review.coreboot.org/c/coreboot/+/36486 : [4] https://qemu-project.gitlab.io/qemu/system/arm/virt.html : [5] https://qemu-project.gitlab.io/qemu/system/riscv/virt.html These render as one paragraph (and without hyperlinks as noted above) ```suggestion [1] https://lore.kernel.org/qemu-devel/1504626814-23124-1-git-send-email-peter.maydell@linaro.org/T/#u \ [2] https://review.coreboot.org/c/coreboot/+/34774 \ [3] https://review.coreboot.org/c/coreboot/+/36486 \ [4] https://qemu-project.gitlab.io/qemu/system/arm/virt.html \ [5] https://qemu-project.gitlab.io/qemu/system/riscv/virt.html ```
https://review.coreboot.org/c/coreboot/+/84046/comment/5758fb14_870ef9e2?usp... : PS1, Line 118: HUTRR94: https://www.usb.org/sites/default/files/hutrr94_-_system_do_not_disturb.pdf : HUTRR116: https://www.usb.org/sites/default/files/hutrr116-systemaccessbilitybinding_2... These will render as one paragraph with no line break.
https://review.coreboot.org/c/coreboot/+/84046/comment/c2c94221_4f853e41?usp... : PS1, Line 121: Review: https://review.coreboot.org/c/coreboot/+/82997 : Review: https://review.coreboot.org/c/coreboot/+/82996 These will render as one paragraph with no line break
https://review.coreboot.org/c/coreboot/+/84046/comment/434734f5_f1fa5611?usp... : PS1, Line 142: ../cbfstool/linux_trampoline.S: Assembler messages: : ../cbfstool/linux_trampoline.S:100: Error: no instruction mnemonic : suffix given and no register operands; can't size : instruction : <builtin>: recipe for target '../cbfstool/linux_trampoline.o' : failed This renders as a single paragraph without the line breaks. Maybe enclose in a code block?
https://review.coreboot.org/c/coreboot/+/84046/comment/2b0a6bfa_2212a8e1?usp... : PS1, Line 183: LBBR Test: : // 1. dump FDT from QEMU like mentioned in aarch64 coreboot doc : // 2. compile u-root however you like (aarch64) : // 3. compile Linux (embed u-root initramfs via Kconfig) : // 4. copy Linux kernel to payloads/leanefi/Image : // 5. copy following coreboot defconfig to configs/defconfig: : CONFIG_BOARD_EMULATION_QEMU_AARCH64=y : CONFIG_PAYLOAD_NONE=n : CONFIG_PAYLOAD_LEANEFI=y : CONFIG_LEANEFI_PAYLOAD=y : CONFIG_LEANEFI_PAYLOAD_PATH="[path-to-linux]/arch/arm64/boot/Image" : CONFIG_LEANEFI_FDT=y : CONFIG_LEANEFI_FDT_PATH="[path-to-dumped-DTB]" : // 6. compile coreboot : make defconfig : make -j$(nproc) : // 7. run qemu like mentioned in coreboot doc (no FIT) : // 8. say hello to u-root and optionally kexec into the next kernel This renders as a single paragraph with no line breaks since markdown ignores newline characters between lines without a blank line separating them. Maybe reformat as an actual numbered list with code blocks for the defconfig and commands?
https://review.coreboot.org/c/coreboot/+/84046/comment/19fb7401_573176e6?usp... : PS1, Line 210: haswell ```suggestion * Numerous updates to autoport tool, including Haswell support. ```
https://review.coreboot.org/c/coreboot/+/84046/comment/20aedb3b_99264978?usp... : PS1, Line 312: ## Increase these by one header level to H3 so that they fall under the "Significant Known and Open Issues" header, as `----` is H2 ```suggestion ### coreboot-wide or architecture-wide issues ```
https://review.coreboot.org/c/coreboot/+/84046/comment/17552312_d25d27ce?usp... : PS1, Line 325: ## Same as above ```suggestion ### Payload-specific issues ```
https://review.coreboot.org/c/coreboot/+/84046/comment/b439a8a5_fae57f3b?usp... : PS1, Line 346: ## Same as above ```suggestion ### Platform-specific issues ```