[coreboot-gerrit] Change in ...coreboot[master]: mainboard: Add ASRock H110M-DVS

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31603 )

Change subject: mainboard: Add ASRock H110M-DVS
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/31603/2/src/mainboard/asrock/h110m/romstage.... 
File src/mainboard/asrock/h110m/romstage.c:

https://review.coreboot.org/#/c/31603/2/src/mainboard/asrock/h110m/romstage.... 
PS2, Line 48: 	mem_cfg->MemorySpdPtr11 = (uintptr_t)blk.spd_array[3];
Huh.. you cannot take pointers from the stackframe and assume their contents are still intact when you reference them later. Was this copied from somewhere else?

Move struct spd_block to .bss (aka declare as global static).