Attention is currently required from: Sean Rhodes.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60754 )
Change subject: mb/starlabs/labtop: Disconnect unused GPIO's
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
File src/mainboard/starlabs/labtop/variants/tgl/gpio.c:
https://review.coreboot.org/c/coreboot/+/60754/comment/9416f6fc_6c7b3bb2
PS6, Line 32: /* GPD2: LAN_WAKE# */
I'd like to keep that one - it's correct, just not used on current the variant.
ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60754
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2050da62f73c0f99fbfef013c22e35225cc480c4
Gerrit-Change-Number: 60754
Gerrit-PatchSet: 6
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Comment-Date: Tue, 15 Feb 2022 13:49:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Sean Rhodes
sean@starlabs.systems
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment