Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44429 )
Change subject: util: Add spd_tools to generate SPDs for TGL boards ......................................................................
Patch Set 15:
(9 comments)
https://review.coreboot.org/c/coreboot/+/44429/9/util/spd_tools/intel/ddr4/R... File util/spd_tools/intel/ddr4/README.md:
https://review.coreboot.org/c/coreboot/+/44429/9/util/spd_tools/intel/ddr4/R... PS9, Line 54: `"1600J", "1600K", "1600L", "1866L", "1866M", "1866N", "2133N", "2133P", : "2133R", "2400P", "2400R", "2400T", "2400U", "2666T", "2666U", "2666V", : "2666W", "2933V", "2933W", "2933Y", "2933AA", "3200W", "3200AA", "3200AC"`
There are multiple traits that differ based on what you are calling "Min CL supported", including tA […]
Done
https://review.coreboot.org/c/coreboot/+/44429/9/util/spd_tools/intel/ddr4/R... PS9, Line 59: `0, 2, 4` bank groups.
It supports 0 bank groups. […]
Done
https://review.coreboot.org/c/coreboot/+/44429/9/util/spd_tools/intel/ddr4/R... PS9, Line 62: `4, 8` banks per group.
Section 8.1.5 of JEDEC spec 4.1.2. […]
Done
https://review.coreboot.org/c/coreboot/+/44429/9/util/spd_tools/intel/ddr4/R... PS9, Line 65: 32
Section 8.1.5 of JEDEC spec 4.1.2. […]
Done
https://review.coreboot.org/c/coreboot/+/44429/9/util/spd_tools/intel/ddr4/R... PS9, Line 65: 1,
See above comment.
Done
https://review.coreboot.org/c/coreboot/+/44429/9/util/spd_tools/intel/ddr4/R... PS9, Line 73: 1, 2, 3, 4, 5, 6, 7, 8`
Section 8.1.7 of JEDEC spec 4.1.2.L-5 R29 has a setting for anywhere from a single die to 8 die.
Done
https://review.coreboot.org/c/coreboot/+/44429/9/util/spd_tools/intel/ddr4/R... PS9, Line 75: Number of bits of the device's address bus.
Is device bus width not the same as DQ width? If not, what is the term that should be used for this […]
Done
https://review.coreboot.org/c/coreboot/+/44429/9/util/spd_tools/intel/ddr4/R... PS9, Line 78: signalLoading`: Refers to loading on signals at the SDRAM balls. Loading on : certain signals (CKE, ODT, etc.) per specification of device stacking as : defined in JESD79-4CNumber of bits of the device's address bus. Valid values: : `"not specified", "single", "multi"`
Will we support 3DS? If not, then you are correct, single die could only map to "not specified". […]
Done
https://review.coreboot.org/c/coreboot/+/44429/9/util/spd_tools/intel/ddr4/R... PS9, Line 89: `1, 2, 3, 4` package ranks.
Section 8.1.13 of JEDEC spec 4.1.2. […]
Done