Hello Edward O'Callaghan,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/37736
to review the following change.
Change subject: mainboard/google/puff: Cleanup dt for pci 15.2 ......................................................................
mainboard/google/puff: Cleanup dt for pci 15.2
Seems nothing special is needed here from coreboot.
BRANCH=none BUG=b:143047058 TEST=./util/abuild/abuild -p none -t google/hatch -x -a
Change-Id: Ief750f98677b2017af78fb0b5bc98e1492dedbe4 Signed-off-by: Edward O'Callaghan quasisec@google.com --- M src/mainboard/google/hatch/variants/puff/overridetree.cb 1 file changed, 1 insertion(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/37736/1
diff --git a/src/mainboard/google/hatch/variants/puff/overridetree.cb b/src/mainboard/google/hatch/variants/puff/overridetree.cb index d5e2e5a..ce5fbc3 100644 --- a/src/mainboard/google/hatch/variants/puff/overridetree.cb +++ b/src/mainboard/google/hatch/variants/puff/overridetree.cb @@ -63,16 +63,7 @@ # RFU - Reserved for Future Use. end # I2C #0 device pci 15.1 off end # I2C #1 - device pci 15.2 on -# chip drivers/i2c/generic -# register "name" = ""PS175"" -# register "desc" = ""PCON PS175"" -# register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C10)" -# register "stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C11)" -# register "has_power_resource" = "1" -# device i2c 15 on end -# end - end # I2C #2 + device pci 15.2 on end # I2C #2, PCON PS175. device pci 15.3 on # chip drivers/i2c/generic # register "name" = ""RTD21""