Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32291 )
Change subject: nb/via/vx900: Use 64 bits to prevent overflow
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/32291/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/32291/1//COMMIT_MSG@9
PS1, Line 9: The bit operations are currently done using 32 bit math.
: Cast the first argument to 64 bits to prevent possible
: overflow.
Doesn't coreboot run in 32-bit mode anyway?
Ok, I'd like to resurrect this issue. Which variables should have the sanity checks? fbufk and tolmk?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32291
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd180f31e8cff797a6499b12bc685daa993aae05
Gerrit-Change-Number: 32291
Gerrit-PatchSet: 1
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 16 Jul 2019 23:52:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Jacob Garber
jgarber1@ualberta.ca
Gerrit-MessageType: comment