[coreboot-gerrit] Change in coreboot[master]: src/soc/intel/common/block/cse: Make hfsts1 common & add helper funct...

[Rizwan Qureshi (Code Review)]

Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35226 )

Change subject: src/soc/intel/common/block/cse: Make hfsts1 common & add helper functions
......................................................................

Patch Set 25:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35226/25//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/35226/25//COMMIT_MSG@9 
PS25, Line 9: Host FW status 1 (FWSTS1/HFSTS1) register definition is common across SoCs,
> That is exactly my concern with making these common. […]

Also it was safe to make the assumptions in the case of opmodes values because backward compatibility is maintained in this regard. The opmodes that we rely on do not change across SoCs.

Nonetheless, will check further and see how we can correctly implement this, taking into account what values will change.