Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44023 )
Change subject: arch/x86/smbios.c: Split out weak functions
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44023/1/src/arch/x86/smbios_weak.c
File src/arch/x86/smbios_weak.c:
PS1:
suggestion: the filename `weak` is a little difficult to understand at a glance, what about smbios_defaults.c ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44023
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd2a4ba52b6b23aad8fd63e66ffa747d49ea713d
Gerrit-Change-Number: 44023
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Wed, 29 Jul 2020 17:14:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment