Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kun Liu, Nick Vaccaro.
Subrata Banik has posted comments on this change by Kun Liu. ( https://review.coreboot.org/c/coreboot/+/85738?usp=email )
Change subject: mb/google/nissa/var/telith: Disable stylus function
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brya/variants/telith/gpio.c:
https://review.coreboot.org/c/coreboot/+/85738/comment/3d98cfe5_6bcc1d4d?usp... :
PS3, Line 45: /* F15 : GSXSRESET# ==> GPIO */
: PAD_CFG_GPO(GPP_F15, 0, DEEP),
: /* F13 : GSXSLOAD ==> GPIO */
: PAD_CFG_GPO(GPP_F13, 0, DEEP),
shouldn't this be `NC` if stylus is not present ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85738?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7b72284ab173633405d5de9541f0ea7520d09658
Gerrit-Change-Number: 85738
Gerrit-PatchSet: 3
Gerrit-Owner: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Rui Zhou
zhourui@huaqin.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Tue, 24 Dec 2024 04:01:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No